Port objection dialog #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
willm30
force-pushed
the
port/270-staking-widget
branch
5 times, most recently
from
0253d36
to
b4222c8
Compare
willm30
force-pushed
the
port/287-objection-dialog
branch
from
f003dd4
to
1ef0561
Compare
willm30
changed the base branch from
port/270-staking-widget
to
port/298-staking-sagas
willm30
force-pushed
the
port/298-staking-sagas
branch
from
ca5cc91
to
f7d7c72
Compare
willm30
force-pushed
the
port/287-objection-dialog
branch
from
1ef0561
to
827956d
Compare
willm30
force-pushed
the
port/298-staking-sagas
branch
from
f7d7c72
to
e891d61
Compare
willm30
force-pushed
the
port/287-objection-dialog
branch
from
d129e29
to
97945c8
Compare
willm30
force-pushed
the
port/298-staking-sagas
branch
3 times, most recently
from
7455d92
to
c7a1241
Compare
willm30
force-pushed
the
port/287-objection-dialog
branch
from
97945c8
to
67d0c0b
Compare
willm30
force-pushed
the
port/298-staking-sagas
branch
from
c7a1241
to
bdf4de7
Compare
willm30
force-pushed
the
port/287-objection-dialog
branch
from
67d0c0b
to
38dc5cd
Compare
willm30
force-pushed
the
port/298-staking-sagas
branch
from
bdf4de7
to
7a11585
Compare
willm30
force-pushed
the
port/287-objection-dialog
branch
5 times, most recently
from
f6f3df2
to
69320de
Compare
willm30
force-pushed
the
port/298-staking-sagas
branch
from
b84ceb6
to
f4f21b1
Compare
willm30
force-pushed
the
port/287-objection-dialog
branch
from
69320de
to
ad403a3
Compare
willm30
force-pushed
the
port/298-staking-sagas
branch
from
f4f21b1
to
4ca5020
Compare
willm30
force-pushed
the
port/287-objection-dialog
branch
from
ad403a3
to
ca9a960
Compare
rdig
approved these changes
Mar 11, 2023
|
Temporarily back to draft as this pr is part of a chain, the head of which needs reworking. |
willm30
force-pushed
the
port/298-staking-sagas
branch
from
4ca5020
to
c8fb2bf
Compare
willm30
force-pushed
the
port/287-objection-dialog
branch
from
ca9a960
to
578cad5
Compare
|
Closing in favour of #344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I recommend testing this pr first : #310 since you'll implicitly be testing the ui.
This ports the objection dialog such that when you click the object button, you see:
New stuff ✨
Resolves #287