-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet auto-detection when accessing Colony #101
Comments
@collinvine typo in "Returning User Workflow, Hardware". 'hope' --> 'home' We might also want to reiterate that if we don't detect metamask or a hardware wallet we bring them to the select wallet screen in #99 |
Meaning the hardware will light up and prompt the user for some action ?
The only action here should be select the available, because it's not entirely clear that Go to Colony will select the first available address. Also the address list is huge, we should show at least 10 |
Sorry, @rdig I missed this when you first posted.
I meant we'll have a screen that prompts the user to select a wallet, similar to how MyCrypto does it. I recognize that they have LOTS of addresses and also a field titled HD Derivation Path which seems to change the list of addresses that appear. You hint at this here:
Do you have a way to simplify this process? I'm a bit perplexed by it.
So you're saying it's a problem with the copy? The intent is to have the button be deactivated until a wallet is selected and then once selected the button is active and the user can proceed to Colony. |
Got it.
We don't need to show the user the derivation path
Not really, since that's the way you "select" which address you want to use. and depending on what address the user has been using in the past, he may (or may not) want to use it again. Let's take this scenario: The use has been using the address with index
Ok, I didn't get this from the visual, thanks for clearing it up. |
I found myself wanting a search field when using MEW to select a wallet. Could we add that in, or we wouldn't have access to query the data? |
Wallet type (eg: software, hardware, metamask) or address ? (eg: 0x123abc...) |
Address |
Wouldn't really work, since we only allow the user to select one address at Login. The only way I see us doing this, is to allow the user to select multiple ones, from multiple wallet types (think checkboxes instead of radio buttons) But I really don't see the immediate benefit to this... |
Or... Do you envision something like the browser remembering previously used addresses, and searching through those ? |
I had something different in mind. Let me explain the problem I had trying to find the address I wanted to use from my Ledger on MEW. I go to unlock my wallet using Ledger on MEW and it gives me a lot of addresses to chose from, seemingly filtered (?) by their derivation path. I knew the address I wanted to use, but I couldn't find it. I paged through hundreds of wallet addresses (5 at a time, mind you) and still couldn't find it. I really just wanted a search field so I could paste the ledger address I wanted to use but couldn't find through their pagination design. |
Yep, we can do that. |
Oh cool. |
Then I think we'll need to design for:
|
If it would be up to me, I wouldn't do pagination. I would just do a fixed height scroll-able list (up to 100 + a load more button) with a search box atop. |
Sure, I'm easily on board with that. The pagination on MEW was not a good ux.
I like it. I'll get with Karol and fix this screen and re-upload it. |
@coyotespike why was this moved to the icebox? |
We need a loading state for the balance. As we won't be able to fetch all at once, and we'll need to defer loading to just the ones the user "sees" . |
Warning about the Ledger Wallet: Due to the way the Ledger Nano S is designed, while it's very "easy"™ to detect it's presence initially, after about 10 minutes of inactivity it will enter "screen-saver" mode which cuts off all communication to the device. (It acts like it's not even connected to the USB port) Because of this, it makes it very un-reliable from a detection standpoint. For some good news, this problem will be mitigated once the |
What does that mean for us? Will we need another screen to alert the user?
Or will the user have to disconnect and reconnect?
…On Wed, Aug 1, 2018 at 4:03 AM Raul ***@***.***> wrote:
Warning about the Ledger Wallet:
Due to the way the Ledger Nano S is designed, while it's very *"easy"™*
to detect it's presence initially, after about 10 minutes of inactivity it
will enter *"screen-saver"* mode which cuts off all communication to the
device. *(It acts like it's not even connected to the USB port)*
Because of this, it makes it very un-reliable from a detection standpoint.
For some good news, this problem will be mitigated once the WebUSB
standard gets wide adoption, and I can access the USB port directly from
the browser.
https://wicg.github.io/webusb/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APBo4MQg9uMgOiZzsTyEPbco8S2SjYTCks5uMYrtgaJpZM4T5W9p>
.
|
That's the problem. We can't tell if the device is not connect or is in standby. In the current state, there's no way to "guess" which is which. So if the device isn't during the initial time period after it was connected (before the standby kicks in), we basically can't detect it. |
@rdig I've uploaded the preloader visual that Karol just created. |
Closing as we are going with different routes to alleviate this problem |
Jobs Story
When I am logging in to Colony
I want the system to detect whether I have metamask or a hardware wallet connected
So that the login process is easier for me
Specs
If a user has either MetaMask or a Hardware wallet connected, we should autodetect to make the login or registration easier.
There are two scenarios that can arise from auto detection:
New User Workflow
If it’s a new user, they will be presented with a screen that prompts them to agree to use their wallet to access Colony.
Auto detection of MetaMask for New Users
We ask the wallet to confirm that they want to use MetaMask to access Colony. They have two actions:
Wallet detection screen
Auto detection of Hardware Wallet for New Users
For auto detecting a hardware wallet, we will first prompt the user to select which wallet they want to access on their hardware wallet. Then they'll have the same two options:
Go To Colony
orChoose a different wallet
.Returning User Workflow
If the user clicks
Open Colony
from the colony.io home page, and we detect it's a returning user (someone who has already created an account on Colony), then we immediately direct them to their Profile page.Questions
The text was updated successfully, but these errors were encountered: