Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CreateDomainButton icon going out of bounds #3374

Merged
merged 1 commit into from May 10, 2022
Merged

Fix CreateDomainButton icon going out of bounds #3374

merged 1 commit into from May 10, 2022

Conversation

ArmandoGraterol
Copy link
Member

This was just a classic case of an absolute element not being inside a relative container.

FireShot Capture 590 - Actions - Colony - wonker - localhost

Resolves #3373

@ArmandoGraterol ArmandoGraterol requested a review from a team May 9, 2022 21:57
@ArmandoGraterol ArmandoGraterol self-assigned this May 9, 2022
danbr
danbr approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@danbr danbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - works for me.....

Screenshot 2022-05-10 at 12 20 16

chinins
chinins approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@chinins chinins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet!

rdig
rdig approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArmandoGraterol ArmandoGraterol force-pushed the bug/issue-3373-create-domain-button-icon branch from 76a9600 to 858cea9 Compare May 10, 2022 21:16
@ArmandoGraterol ArmandoGraterol merged commit f3e8cba into master May 10, 2022
@ArmandoGraterol ArmandoGraterol deleted the bug/issue-3373-create-domain-button-icon branch May 10, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbr danbr danbr approved these changes

@rdig rdig rdig approved these changes

@chinins chinins chinins approved these changes

Assignees

@ArmandoGraterol ArmandoGraterol

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with adding new team button icon on scroll
4 participants
@ArmandoGraterol @danbr @rdig @chinins