Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification form validation #4150

Open
wants to merge 5 commits into
base: feature/4138-verification-form
Choose a base branch
from

Conversation

agnieszkajarosikloj
Copy link

@agnieszkajarosikloj agnieszkajarosikloj commented Jan 26, 2023

Description

This PR adds form validation and shows if there are any errors in the form.
Validation is written in Yup. Each step of the form is validated separately. If there are any errors message is displayed (above the continue button). User sees error counter and can click on Fix it button.

To test go to /incorporation/verification route.

New stuff

  • form validation

Changes 🏗

  • Added hook in core Select component that opens dropdown after clicking on "Fix it" button.

Resolves #4123

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@agnieszkajarosikloj agnieszkajarosikloj marked this pull request as ready for review February 3, 2023 14:20
@agnieszkajarosikloj agnieszkajarosikloj requested a review from a team February 3, 2023 14:20
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being migrated to the new UI/UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants