Update README/package.json files #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdig
approved these changes
May 21, 2018
| @@ -32,6 +32,7 @@ | |||
| "webpack": "^4.5.0", | |||
| "webpack-cli": "^2.0.14" | |||
| }, | |||
| "contributors": ["Christian Maniewski <chris@colony.io>", "James Lefrère <james@colony.io>"], | |||
There was a problem hiding this comment.
This should be authors, as contributors are a lot more: https://github.com/JoinColony/colonyJS/graphs/contributors
There was a problem hiding this comment.
Oh, I just now read the PR's description:
Replaces author with contributors in all package.json files
Weird...
There was a problem hiding this comment.
True! But then again, they didn't directly contribute to our repo 🙃
npm just references author or contributors, so I guess we can go with this? https://docs.npmjs.com/files/package.json
There was a problem hiding this comment.
But what happens when there are "real" contributors ? :)
JamesLefrere
force-pushed
the
maintenance/update-readmes
branch
from
29daac6
to
bd037f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates all README files so that they are written in the same style and link to the colonyJS docs site where appropriate.
Other changes (e.g. bug fixes, UI tweaks, refactors)
Readme.mdtoREADME.md(just so we have a standard)authorwithcontributorsin allpackage.jsonfilescolony-json GithubContributes to #100