Fix ColonyClient params #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ContractClients should be constructed with a `query` property in the first parameter (not as a second parameter)
chmanie
pushed a commit
that referenced
this pull request
May 2, 2023
Improve cli setup and service command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was another bug introduced in #95 which I (and Flow, and the tests) didn't catch 馃檲
The
ContractClientclass constructor (whichColonyClientis derived from) accepts one object parameter, not two; the query to load the contract was being passed in as a second query, instead of as a property of the object.This PR fixes that and amends the tests.