Skip to content

Commit

Permalink
remove ratedOnTime task property
Browse files Browse the repository at this point in the history
  • Loading branch information
sekl committed Feb 25, 2018
1 parent 2ba895c commit c85b69b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 0 additions & 2 deletions contracts/ColonyStorage.sol
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ contract ColonyStorage is DSAuth {
struct Role {
// Address of the user for the given role
address user;
// Has the user work been rated on time
bool ratedOnTime;
// Rating the user received
uint8 rating;
}
Expand Down
5 changes: 1 addition & 4 deletions contracts/ColonyTask.sol
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ contract ColonyTask is ColonyStorage, DSMath {
tasks[taskCount] = task;
tasks[taskCount].roles[MANAGER] = Role({
user: msg.sender,
ratedOnTime: false,
rating: 0
});

Expand Down Expand Up @@ -189,7 +188,6 @@ contract ColonyTask is ColonyStorage, DSMath {
// WIP: ensure rating within 1-3

Role storage role = tasks[_id].roles[_role];
role.ratedOnTime = true;
role.rating = _rating;
}

Expand All @@ -213,7 +211,6 @@ contract ColonyTask is ColonyStorage, DSMath {
{
tasks[_id].roles[_role] = Role({
user: _user,
ratedOnTime: false,
rating: 0
});
}
Expand Down Expand Up @@ -324,7 +321,7 @@ contract ColonyTask is ColonyStorage, DSMath {

function getTaskRole(uint256 _id, uint8 _idx) public view returns (address, bool, uint8) {
Role storage role = tasks[_id].roles[_idx];
return (role.user, role.ratedOnTime, role.rating);
return (role.user, role.rating);
}

function getTaskSkill(uint256 _id, uint256 _idx) public view returns (uint256) {
Expand Down

0 comments on commit c85b69b

Please sign in to comment.