RPC API: configset doesn't update the persistent config

[manasgandy]

The configset API doesn't update the configuration file in the datadir. The configuration persists while the backend is running but loses them once it is stopped. Please fix this or let me know how to.

My guess is to use the following function:

joinmarket-clientserver/jmclient/jmclient/configure.py

Line 810 in ecd1083

def update_persist_config(section, name, value):

Also, it will be good to have a test for this API call

[AdamISZ]

See #996 (comment) and as per docs here, "only in memory".

My guess is to use the following function:

Yeah, understood. The thing is, when I wrote that it felt like a really dumb hacky solution (using regex..) :) I just did it for the Qt GUI; it was particularly the inability to keep comments from a direct "dump object to disk" approach that was bothering me (see the function's docstring for more). Because the comments in our config are super-important.

If you can make that hacky update_persist_config function do the job then that's fine, I was hoping at some point there would be a more well constructed solution.

[AdamISZ]

I guess probably just create a subclass or wrapper class for ConfigParser that allows a comment to be attached to each config var, then write the serialize/deserialize routine for it.

[theborakompanioni]

Any news on this? I think people are quite confused that their config settings do not survive node restarts..
What do you think? Is this something worth having?

[editwentyone]

that would be so helpful, can this be pushed trough?

[kristapsk]

We could just reuse existing hackish Qt GUI code for this I think. And optional boolean parameter should be added configset, that indicates whether changes should be permanent or not.

[theborakompanioni]

We could just reuse existing hackish Qt GUI code for this I think. And optional boolean parameter should be added configset, that indicates whether changes should be permanent or not.

That would be so great. It really is counterintuitive currently. 🙏