Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials/auth for client connection #3

Open
AdamISZ opened this issue Nov 25, 2016 · 3 comments
Open

Credentials/auth for client connection #3

AdamISZ opened this issue Nov 25, 2016 · 3 comments

Comments

@AdamISZ
Copy link
Member

AdamISZ commented Nov 25, 2016

Also, encryption/TLS. Not sure of the right approach here; it looks like it's fairly easy to add credentials to the AMP connection. The connection is currently hardcoded to localhost, but clearly it would be either nice or essential to add security to this inter process communication, depending on how you look at it.

@AdamISZ
Copy link
Member Author

AdamISZ commented Feb 14, 2017

TLS was added in 5d3fbe9 although only basic (self-signed cert). Auth still open.

@roshii
Copy link
Contributor

roshii commented Sep 1, 2023

I will be working on this one next.

I'm thinking at something similar to https://github.com/bitcoin/bitcoin/blob/master/doc/JSON-RPC-interface.md#security reusing/adapting JMTokenAuthority from #1480

As far as I see it, authentication would be applied to both daemon and wallet RPC.

@AdamISZ
Copy link
Member Author

AdamISZ commented Sep 1, 2023

I will be working on this one next.

I'm thinking at something similar to https://github.com/bitcoin/bitcoin/blob/master/doc/JSON-RPC-interface.md#security reusing/adapting JMTokenAuthority from #1480

As far as I see it, authentication would be applied to both daemon and wallet RPC.

Interesting idea to connect these. Look forward to it. At some point there was code to do this with self-signed certs, I'm not sure if it's still functional, because I think there were only a couple of people using it, based on the idea of having jmdaemon on a remove (virtual) machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants