fix standalone joinmarketd listening on all interfaces #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undeath
force-pushed
the
listeninterface-fix
branch
from
f2ba06e
to
2edd615
Compare
|
Thanks, testing now. |
|
This is working well, but there's an issue: part of the intention with the 4 separate packages was for people to be able to install just (jmclient, jmbase), thus not requiring the libsodium dependency or IRC code. Hence see note to code, if that's OK and you change it I'll merge directly. |
AdamISZ
reviewed
Nov 17, 2017
jmclient/jmclient/client_protocol.py
Outdated
| @@ -29,6 +20,7 @@ | |||
| load_program_config, get_log, get_p2sh_vbyte, | |||
| RegtestBitcoinCoreInterface) | |||
| from jmbase import _byteify | |||
| from jmdaemon import start_daemon | |||
There was a problem hiding this comment.
Want to avoid this unconditional import here, so jmclient doesn't have a jmdaemon dependency by default; can you put it in the try/except block in if daemon: in start_reactor?
undeath
force-pushed
the
listeninterface-fix
branch
from
2edd615
to
467053b
Compare
AdamISZ
added a commit
that referenced
this pull request
Nov 17, 2017
467053b fix standalone joinmarketd listening on all interfaces (undeath)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #109
cleaned up some imports, too