Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Guardians (Share Activation link) #1097

Closed
JGDoh opened this issue Aug 18, 2021 · 10 comments
Closed

Key Guardians (Share Activation link) #1097

JGDoh opened this issue Aug 18, 2021 · 10 comments
Assignees
Labels

Comments

@JGDoh
Copy link
Collaborator

JGDoh commented Aug 18, 2021

Is your feature request related to a problem? Please describe.
Currently user has to select Copy and then past in relevant messages and other communication apps.

Describe the solution you'd like
INSTEAD the user should be able to select SEND (represented by the icon) and then it will open the system dialogue to sent via other messaging apps.

Group 605

@JGDoh JGDoh added the story label Aug 18, 2021
@JGDoh JGDoh added this to To do in Release V2.1.0 via automation Aug 18, 2021
@JGDoh JGDoh changed the title Guardians (Share Activation link) Key Guardians (Share Activation link) Aug 18, 2021
@gguij004 gguij004 moved this from To do to QA/Product in Release V2.1.0 Aug 20, 2021
@buildc0de
Copy link
Collaborator

buildc0de commented Aug 23, 2021

🛑 @JGDoh What are the steps to get to this screen? Is there a test account I could use for testing this? testingseeds?

@gguij004
Copy link
Collaborator

gguij004 commented Aug 23, 2021

🛑 @JGDoh What are the steps to get to this screen? Is there a test account I could use for testing this? testingseeds?

Hey Sky, try my testing account "faruandluca1" you should be able to test this with it.

  • Go to Login Screen
  • Click Recover account
  • type account username
  • click on account
  • click share button

@buildc0de
Copy link
Collaborator

Thanks, @gguij004 🙏 That worked and I was able to test the case below:

  1. Run the app.
  2. If logged in, log out.
  3. Tap Login screen > Lost your key? Recover your account here.
  4. Enter Username > faruandluca1.
  5. Tap on Faru Luca or Next.
  6. Observe a generated link under Link to Activate Key Guardians.
  7. Tap the share button.
  8. Observe the sharing options.

@buildc0de
Copy link
Collaborator

However, if I:

  • Cancel the recovery process
  • Open the activation link in the browser
  • Observe the exception below

@gguij004 Any ideas what's happening? (I can dig in deeper, if need be)

Screen Shot 2021-08-25 at 14 23 16

@buildc0de
Copy link
Collaborator

Any ideas what's happening? (I can dig in deeper, if need be)

Hmm, might be networking issues here at the airport. Although, I tried on a VPN connection and I'm getting the same error 🤷‍♂️ I'll try again later.

@RaulUrtecho
Copy link
Collaborator

Usually it is the ConnectionNotifier class that to be honest is still not entirely clear to me, its use, and sometimes it fails to ping an end-point.
To avoid those annoying errors I deactivate all my debug flags (uncaught exceptions and all exceptions).

@buildc0de
Copy link
Collaborator

OK, seems to work OK on my current connection.
Test Case 1 passes

@buildc0de buildc0de moved this from QA/Product to Done in Release V2.1.0 Aug 26, 2021
@buildc0de
Copy link
Collaborator

Probably out of scope for this ticket and to be addressed separately, but the request screen could use Spanish localization:

Simulator Screen Shot - 3 (@skyt) - 2021-08-26 at 15 31 37

@RaulUrtecho
Copy link
Collaborator

Probably out of scope for this ticket and to be addressed separately, but the request screen could use Spanish localization:

Simulator Screen Shot - 3 (@skyt) - 2021-08-26 at 15 31 37

@buildc0de was this already fixed? maybe a new ticked to be able to close this

@buildc0de
Copy link
Collaborator

@RaulUrtecho As we discussed in the last meeting, I will be looking into implementing https://weblate.org, so we can close this 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

4 participants