Skip to content

Commit

Permalink
Fix #311353: Playback fix for diminished chords
Browse files Browse the repository at this point in the history
Backport of musescore#8170
  • Loading branch information
Mystic-Slice authored and Jojo-Schmitz committed Aug 30, 2021
1 parent b72cf2d commit 10b3a2a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions libmscore/realizedharmony.cpp
Expand Up @@ -412,6 +412,8 @@ RealizedHarmony::PitchMap RealizedHarmony::getIntervals(int rootTpc, bool litera
ret.insert(step2pitchInterval(3, -1) + RANK_MULT*RANK_3RD, tpcInterval(rootTpc, 3, -1)); //min3
if (!(omit & (1 << 5)))
ret.insert(step2pitchInterval(5, -1) + RANK_MULT*RANK_3RD, tpcInterval(rootTpc, 5, -1)); //dim5
if (!(omit & (1 << 7)) && quality == "half-diminished")
ret.insert(step2pitchInterval(7, -1) + RANK_MULT * RANK_7TH, tpcInterval(rootTpc, 7, -1)); //min7
alt5 = true;
}
else { //major or dominant
Expand Down Expand Up @@ -450,6 +452,8 @@ RealizedHarmony::PitchMap RealizedHarmony::getIntervals(int rootTpc, bool litera
ret.insert(11 + RANK_MULT*RANK_7TH, tpcInterval(rootTpc, 7, 0));
else if (quality == "diminished")
ret.insert(9 + RANK_MULT*RANK_7TH, tpcInterval(rootTpc, 7, -2));
else if (quality == "half-diminished")
; // 7th note already added when handling chord quality
else //dominant or augmented or minor
ret.insert(10 + RANK_MULT*RANK_7TH, tpcInterval(rootTpc, 7, -1));
}
Expand Down

0 comments on commit 10b3a2a

Please sign in to comment.