Fix GH#9447: Crash on removing accidental from ambitus

Fixed by just ignoring the operation, i.e. not removing the accidental. Instead do this via the Inspector. Backport of musescore#9831
Jojo-Schmitz · Nov 28, 2021 · 484c3c9 · 484c3c9
1 parent bf04337
commit 484c3c9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/libmscore/ambitus.cpp b/libmscore/ambitus.cpp
@@ -629,6 +629,16 @@ void Ambitus::updateRange()
             }
       }
 
+void Ambitus::remove(Element* e)
+      {
+      if (e->type() == ElementType::ACCIDENTAL) {
+            //! NOTE Do nothing (removing _topAccid or _bottomAccid)
+            return;
+            }
+
+      Element::remove(e);
+      }
+
 //---------------------------------------------------------
 //   getProperty
 //---------------------------------------------------------

diff --git a/libmscore/ambitus.h b/libmscore/ambitus.h
@@ -90,6 +90,8 @@ class Ambitus final : public Element {
       bool      readProperties(XmlReader&) override;
       QString   accessibleInfo() const override;
 
+      void remove(Element*) override;
+
       // properties
       QVariant getProperty(Pid ) const;
       bool setProperty(Pid propertyId, const QVariant&);