Fix crash on lyrics line layout

Backport of musescore#19972, commit 38
Jojo-Schmitz · Nov 16, 2023 · 7604a87 · 7604a87
1 parent 9869614
commit 7604a87
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/libmscore/layout.cpp b/libmscore/layout.cpp
@@ -4659,8 +4659,11 @@ void Score::layoutSystemElements(System* system, LayoutContext& lc)
 
       layoutLyrics(system);
 
-      // here are lyrics dashes and melisma
-      for (Spanner* sp : _unmanagedSpanner) {
+      // Layout lyrics dashes and melisma
+      // NOTE: loop on a *copy* of unmanagedSpanners because in some cases
+      // the underlying operation may invalidate some of the iterators.
+      std::set<Spanner*> unmanagedSpanners = _unmanagedSpanner;
+      for (Spanner* sp : unmanagedSpanners) {
             if (sp->tick() >= etick || sp->tick2() <= stick)
                   continue;
             sp->layoutSystem(system);