Skip to content

Commit

Permalink
Force building 32-bit Windows on GitHub CI
Browse files Browse the repository at this point in the history
and allow "Save online" even for an unstable build in GUI
and on the commandline.
Temp. measure... needed only as long as there is no 'official' release
  • Loading branch information
Jojo-Schmitz committed Dec 6, 2021
1 parent b8bf8ea commit a6a98f1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ jobs:
if [[ "$BUILD_MODE" == "testing_build" || "$BUILD_MODE" == "stable_build" ]]; then
DO_BUILD='true'
fi
DO_BUILD='true'
echo "!! ATTENTION !! Windows x32 build run only for 'testing_build' and 'stable_build', and SKIP for 'pull requests' and nightly"
echo "DO_BUILD=$DO_BUILD" >> $GITHUB_ENV
echo "DO_BUILD: $DO_BUILD"
Expand Down
2 changes: 2 additions & 0 deletions mscore/cloud/uploadscoredialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ namespace Ms {

void MuseScore::showUploadScoreDialog()
{
#if 0
if (MuseScore::unstable()) {
QMessageBox::warning(this, tr("Save online"), tr("Saving scores online is disabled in this unstable prerelease version of MuseScore."));
return;
}
#endif
if (!currentScore())
return;
if (!currentScore()->sanityCheck(QString())) {
Expand Down
2 changes: 2 additions & 0 deletions mscore/file.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3511,10 +3511,12 @@ static void parseSourceUrl(const QString& sourceUrl, int& uid, int& nid)

bool MuseScore::saveOnline(const QStringList& inFilePaths)
{
#if 0
if (MuseScore::unstable()) {
qCritical() << qUtf8Printable(tr("Error: Saving scores online is disabled in this unstable prerelease version of MuseScore."));
return false;
}
#endif
if (!_loginManager->syncGetUser()) {
return false;
}
Expand Down

0 comments on commit a6a98f1

Please sign in to comment.