Fix GH#145: Crash going from page to continuous view and then clicking on score element

[Jojo-Schmitz]

Resolves: #145
2nd attempt, after #146 failed, resp. caused #150

[worldwideweary]

Hm, this still seems to cause the problem the other guy mentioned with the footers not working right

It seems like the problem is that Mu4 has things like resetExplicitParent and text->moveToDummy(); ability which the MS3 codebase does not, but I might be wrong. Looks like that function some how makes the parent be attached to a "dummy" element founded in the score itself and not the page.... and Mu4 doesn't have the crash related to what i was getting in "3.7"... I'll see if I can figure something out there

Update: Nevermind, I had some changes remaining in the code while checking this. This should take care of both problems (i think).... since thetext->layout()function checks for a valid parent and sets offset to 0.0 if not, whereas setting parent to nullptr here after layout will bypass that problem in #150 all the while, so far, I'm not experiencing the crashes in continuous view as related in #145 so this seems good. Bunch of pretzel logic though. Feels like a re-vamp would help, but that isn't relevant. This makes the setting to nullptr in the drawing function redundant, it seems

Aside: never hurts to use nullptr and not the integer zero if you're not a "Vanilla C"-ist

[Jojo-Schmitz]

Hmm, I'm confused now (again), does this change fix your issue or is it no longer needed?

[worldwideweary]

Hey. This fixes the issue. But it looks like you merged #146 which means in a sense might need to do something else:

for instance needs to be reverted and i'm not sure what's the point of this:

If you were to revert that and then just apply #151... that would fix the original problem it seems to me. just that one setting parent to nullptr after the layout as this PR shows

[Jojo-Schmitz]

That converterMode to unrollRepeats change is entrirely unrelated (and fixes #143).
Reverting your (Page*)this to (0) change was needed to prevent #150.

The question is whether your issue #145 still exists and whether that one-line change of mine does any good?

[worldwideweary]

if all things were the same as they were at the moment of my posting the issue, and the only change from then was that there was:

text->setParent(nullptr);

after the layout as this PR has it, yes, it will fix the issue.

[worldwideweary]

So long as #146 is reverted, should be good to go.

[Jojo-Schmitz]

It is. This is merged now