Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH#22313: Set correct stem direction on pasting notes on a drum staff #441

Merged
merged 1 commit into from
May 14, 2024

Conversation

Jojo-Schmitz
Copy link
Owner

@Jojo-Schmitz Jojo-Schmitz commented Apr 25, 2024

Backport of musescore#22575

Resolves: musescore#22313
Resolves: musescore#22712

@Jojo-Schmitz
Copy link
Owner Author

Jojo-Schmitz commented Apr 25, 2024

mtests pass only if one of the new tests is disabled, else it crashes:

10/62 Test #11: tst_copypaste ....................***Failed    1.95 sec
ASAN:DEADLYSIGNAL
=================================================================
==13459==ERROR: AddressSanitizer: SEGV on unknown address 0x0000000002f0 (pc 0x55be81b12063 bp 0x7ffef6ce8c60 sp 0x7ffef6ce8c50 T0)
==13459==The signal is caused by a READ memory access.
==13459==Hint: address points to the zero page.
    #0 0x55be81b12062 in Ms::MeasureBaseList::first() const /home/runner/work/MuseScore/MuseScore/libmscore/score.h:157
    #1 0x55be823e077b in Ms::Score::firstMeasure() const /home/runner/work/MuseScore/MuseScore/libmscore/score.cpp:1624
    #2 0x55be81ab5d17 in TestCopyPaste::copypastenote(QString const&, Ms::Fraction) /home/runner/work/MuseScore/MuseScore/mtest/libmscore/copypaste/tst_copypaste.cpp:522
    #3 0x55be81abcdf8 in TestCopyPaste::copyPasteNoteDrumStaff() (/home/runner/work/MuseScore/MuseScore/build.debug/mtest/libmscore/copypaste/tst_copypaste+0x402df8)
    #4 0x55be81ab6cdf in TestCopyPaste::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) /home/runner/work/MuseScore/MuseScore/build.debug/mtest/libmscore/copypaste/tst_copypaste_autogen/include/tst_copypaste.moc:265
    #5 0x7f846c478815 in QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const (/home/runner/work/MuseScore/Qt/598/lib/libQt5Core.so.5+0x285815)
    #6 0x7f846ec0b073  (/home/runner/work/MuseScore/Qt/598/lib/libQt5Test.so.5+0x14073)
    #7 0x7f846ec0b995  (/home/runner/work/MuseScore/Qt/598/lib/libQt5Test.so.5+0x14995)
    #8 0x7f846ec0bf81  (/home/runner/work/MuseScore/Qt/598/lib/libQt5Test.so.5+0x14f81)
    #9 0x7f846ec0c458 in QTest::qExec(QObject*, int, char**) (/home/runner/work/MuseScore/Qt/598/lib/libQt5Test.so.5+0x15458)
    #10 0x55be81ab68bc in main /home/runner/work/MuseScore/MuseScore/mtest/libmscore/copypaste/tst_copypaste.cpp:536
    #11 0x7f846bcd9082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082)
    #12 0x55be81aa467d in _start (/home/runner/work/MuseScore/MuseScore/build.debug/mtest/libmscore/copypaste/tst_copypaste+0x3ea67d)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV /home/runner/work/MuseScore/MuseScore/libmscore/score.h:157 in Ms::MeasureBaseList::first() const
==13459==ABORTING

need to investigate

@Jojo-Schmitz Jojo-Schmitz marked this pull request as draft April 25, 2024 21:16
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3.x-perc-paste branch 5 times, most recently from cf3d296 to 5f5abe0 Compare May 14, 2024 11:08
@Jojo-Schmitz
Copy link
Owner Author

Jojo-Schmitz commented May 14, 2024

Seems it doesn't like that score to be a 4.4 one, no such problem with the other score though, seems strange,..

@Jojo-Schmitz Jojo-Schmitz marked this pull request as ready for review May 14, 2024 11:10
Backport of musescore#22575

Plus some includes cleanup
Plus an entirely unrelated debug message fix
@Jojo-Schmitz Jojo-Schmitz merged commit 66e6840 into 3.x May 14, 2024
@Jojo-Schmitz Jojo-Schmitz deleted the 3.x-perc-paste branch May 14, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants