forked from musescore/MuseScore
-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix superfluous clefs after every system break on Capella import #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
3.x-capella-import
branch
from
May 3, 2024 14:51
824f0da
to
595d822
Compare
Jojo-Schmitz
added a commit
that referenced
this pull request
May 3, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
force-pushed
the
3.x-capella-import
branch
from
May 3, 2024 19:23
595d822
to
2c88417
Compare
Jojo-Schmitz
added a commit
that referenced
this pull request
May 3, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
force-pushed
the
3.x-capella-import
branch
3 times, most recently
from
May 5, 2024 10:52
5e9dfde
to
9aa57b2
Compare
Jojo-Schmitz
added a commit
that referenced
this pull request
May 5, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
added a commit
that referenced
this pull request
May 5, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
added a commit
that referenced
this pull request
May 5, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
added a commit
that referenced
this pull request
May 5, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
added a commit
that referenced
this pull request
May 5, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
added a commit
that referenced
this pull request
May 5, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
added a commit
that referenced
this pull request
May 5, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
force-pushed
the
3.x-capella-import
branch
2 times, most recently
from
May 5, 2024 14:32
3c3bbfe
to
92e18ad
Compare
Jojo-Schmitz
added a commit
that referenced
this pull request
May 5, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
force-pushed
the
3.x-capella-import
branch
2 times, most recently
from
May 5, 2024 15:28
3852abe
to
5c64284
Compare
Jojo-Schmitz
added a commit
that referenced
this pull request
May 5, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
force-pushed
the
3.x-capella-import
branch
from
May 5, 2024 16:05
5c64284
to
35042ec
Compare
Jojo-Schmitz
changed the title
Fix superfluous clefs after every system break on Capella .capx import
Fix superfluous clefs after every system break on Capella import
May 5, 2024
Jojo-Schmitz
added a commit
that referenced
this pull request
May 5, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
added a commit
that referenced
this pull request
May 5, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
added a commit
that referenced
this pull request
May 5, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
Jojo-Schmitz
added a commit
that referenced
this pull request
May 6, 2024
For some strange reason that also fixes superfluous key signatures. Port of #462
For some strange reason that also fixes superfluous key signatures.
Jojo-Schmitz
force-pushed
the
3.x-capella-import
branch
from
May 6, 2024 05:58
35042ec
to
a7746e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some strange reason that also fixes superfluous key signatures.
Resolves: https://musescore.org/de/node/363553
Capella apparently repeats clef, key- and time signature on every start of a system.
If you then remove the system break(s), and that results in the systems to automatically break at a different spot, at the first measure after the previous system break there will be a clef and a key signature, even if it is the same as already active.
This bug annoyed me quite a bit back in the Mu1 days, but it took me until today to get to the bottom of it.