Add an option for a different export path #6
Conversation
ecstrema
commented
Nov 22, 2019
ecstrema
commented
- refactor the naming filenames to be more easily understandable
- add the option to export in a different folder
- add verification that the score was able to be exported
- save the last export and import path used
|
This is the merge to mac branch. I have not tested it under windows or linux yet. |
|
Actually I didn't need another PR (but it doesn't harm either), just wanted you to be able to check whether it works on Mac (which I can't test) |
ecstrema
force-pushed
the
mac
branch
2 times, most recently
from
b4af54f
to
a2412f2
Compare
|
had to remove the setting to save the last opened time as it didn't work on mac. |
Actually, it looks like it's done by default. No idea why, though. |
ecstrema
force-pushed
the
mac
branch
5 times, most recently
from
fa06641
to
26ffec4
Compare
|
I'll correct the master branch when I get some time, but that might be in a month, when the exams are over. |
1) refactor the naming filenames to be more easily understandable 2) add the option to export in a different folder 3) add verification that the score was able to be exported 4) save the last export and import path used
|
once this will be done, I have a new branch which allows you for batch transposing: |
|
|
| resultText.append("%1 → %2".arg(fileName).arg(outFormats.extensions[j])) | ||
| } | ||
| if (srcModifiedTime > fileScore.modifiedTime()) { | ||
| var res = writeScore(thisScore, fileScore.source, outFormats.extensions[j]) |
There was a problem hiding this comment.
Still an indent issue here, but I'll fix it myself
|
Looking forward to the batch transpose PR ;-) Try to make sure to 'recycle' strings from MuseScore for that, from its Transpose dialog and use a similar set of options too |
| @@ -340,14 +340,22 @@ MuseScore { | |||
| } // RowLayout | |||
| CheckBox { | |||
| id: exportExcerpts | |||
| text: /*qsTr("Export linked parts")*/ qsTranslate("action", "Export parts") | |||
| text: /*qsTr("Export linked parts")*/ qsTranslate("action", "Export Parts") | |||
There was a problem hiding this comment.
I had to revert this change, this string gets 'recycled' from MuseScore, so need to follow the spelling there in order to get translated properly
|
Using the same set of options would take more time than exposing the transpose dialog to the plugin API, waiting for the PR to be merged, and using it only then, so I won't do it now, but until it gets done, some people might be happy to use the current version. |
|
@Marr11317 please check https://musescore.org/en/node/309463, this doesn't seem to be working (anymore?) |
|
Ok, I'll look at it this week. |
|
It works perfectly for me... |
|
|
