Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect(?) output for test data #27

Open
Yamahari opened this issue Aug 1, 2021 · 5 comments
Open

Incorrect(?) output for test data #27

Yamahari opened this issue Aug 1, 2021 · 5 comments
Labels

Comments

@Yamahari
Copy link

Yamahari commented Aug 1, 2021

Hi,
I was trying out gBolt on some test data I created and I am not sure whether or not I am getting the expected output.
I tested the same data on a gaston miner implementation and provided the seemingly correct output in the following .zip.

gBolt-Tests.zip

"graphs_numeric.lg" is the input file, "graphs.lg" is the original file with string labels, i also plotted the input and output graphs for visual aid.

Maybe you can take a look 🙂

@Jokeren
Copy link
Owner

Jokeren commented Aug 1, 2021

Thanks for the data. Do you mean gBolt's result is different from gaston's?

@Jokeren Jokeren added the bug label Aug 1, 2021
@Yamahari
Copy link
Author

Yamahari commented Aug 1, 2021

Yes very different, the output looks really odd, but I am not sure whether or not I am at fault for providing a faulty input/ gSpan is not able to handle this kind of graph/implementation bug
I used the gaston miner implemented here https://github.com/timtadh/parsemis

@Jokeren
Copy link
Owner

Jokeren commented Aug 1, 2021

It's good to know the other project.

The graph data you attached seems violating gspan/gbolt's specification.

https://github.com/Jokeren/gBolt#input-specification

<vertex-id> must be contiguous without gaps

@Jokeren
Copy link
Owner

Jokeren commented Aug 1, 2021

I'll take a further look once have time. The code itself does not force the constraint and I forgot why I wrote the specification like this.

@Yamahari
Copy link
Author

Yamahari commented Aug 2, 2021

I tried with ordered vertices and the output seems to be the same, here's the input file with ordered
graphs_numeric.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants