Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript rewrite #22

Merged
merged 15 commits into from
Nov 20, 2019
Merged

Typescript rewrite #22

merged 15 commits into from
Nov 20, 2019

Commits on Nov 18, 2019

  1. Add typescript, with prettier for code formatting

    @swsnr
    swsnr committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    dba1662 View commit details
    Browse the repository at this point in the history

  2. Use built-in getSettings function

    @swsnr
    swsnr committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    0f682a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Rewrite extension.js in type script 

    Go fully typed, and get rid of mutable things.  In particular

- turn the provider from a class into a object,
- pass all things as parameters,
- evaluate settings on the fly,
- mutate no globals other than the registered provider.

Search prefix is gone; I have no use for it, and figured it wasn't worth
porting over.
    @swsnr
    swsnr committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    a045c73 View commit details
    Browse the repository at this point in the history

  2. Remove compiled schema 

    gnome-extensions pack automatically builds the schema
    @swsnr
    swsnr committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    3018b65 View commit details
    Browse the repository at this point in the history

  3. Remove mention of search prefix from README

    @swsnr
    swsnr committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    72fee54 View commit details
    Browse the repository at this point in the history

  4. Add node script to pack extension

    @swsnr
    swsnr committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    3c7c16a View commit details
    Browse the repository at this point in the history

  5. Setup eslint

    @swsnr
    swsnr committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    6f84712 View commit details
    Browse the repository at this point in the history

  6. Use Map to avoid mutable objects

    @swsnr
    swsnr committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    1bfd056 View commit details
    Browse the repository at this point in the history

  7. Add log function

    @swsnr
    swsnr committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    742f283 View commit details
    Browse the repository at this point in the history

  8. Set settings schema for getSettings

    @swsnr
    swsnr committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    bd61ce6 View commit details
    Browse the repository at this point in the history

  9. Slightly cleanup prefs.js

    @swsnr
    swsnr committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    dd8e8bb View commit details
    Browse the repository at this point in the history

  10. Remove prefix widget

    @swsnr
    swsnr committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    88e51e2 View commit details
    Browse the repository at this point in the history

  11. Bump minimum support version 

    That's the only thing I tested with, and I'm not sure how far back ES6
support really goes.
    @swsnr
    swsnr committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    fff8cf0 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Add missing search provider properties

    @swsnr
    swsnr committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    8dfa85a View commit details
    Browse the repository at this point in the history

  2. Extract function to register a provider 

    Reduces nesting :)
    @swsnr
    swsnr committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    a82c122 View commit details
    Browse the repository at this point in the history