Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, giraffate/clippy-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

[clippy] reported by reviewdog 🐶 <pre><code>warning: fields `constructor`, `contract`, and `metadata` are never read --> crates/decode/src/utils/constructor.rs:9:9 | 8 | pub struct Constructor { | ----------- fields in this struct 9 | pub constructor: Vec<u8>, | ^^^^^^^^^^^ 10 | pub contract: Vec<u8>, | ^^^^^^^^ 11 | pub metadata: Vec<u8>, | ^^^^^^^^ | = note: `Constructor` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default </code></pre> Raw Output: crates/decode/src/utils/constructor.rs:8:12:w: <pre><code>warning: fields `constructor`, `contract`, and `metadata` are never read --> crates/decode/src/utils/constructor.rs:9:9 | 8 | pub struct Constructor { | ----------- fields in this struct 9 | pub constructor: Vec<u8>, | ^^^^^^^^^^^ 10 | pub contract: Vec<u8>, | ^^^^^^^^ 11 | pub metadata: Vec<u8>, | ^^^^^^^^ | = note: `Constructor` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: usage of a legacy numeric method --> crates/cfg/src/core/mod.rs:77:15 | 77 | u128::max_value(), | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 77 | u128::MAX, | ~~~ </code></pre> Raw Output: crates/cfg/src/core/mod.rs:77:15:w: <pre><code>warning: usage of a legacy numeric method --> crates/cfg/src/core/mod.rs:77:15 | 77 | u128::max_value(), | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 77 | u128::MAX, | ~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> crates/decompile/src/core/out/source.rs:303:26 | 303 | fn indent_source(source: &mut Vec<String>) { | ^^^^^^^^^^^^^^^^ help: change this to: `&mut [String]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default </code></pre> Raw Output: crates/decompile/src/core/out/source.rs:303:26:w: <pre><code>warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> crates/decompile/src/core/out/source.rs:303:26 | 303 | fn indent_source(source: &mut Vec<String>) { | ^^^^^^^^^^^^^^^^ help: change this to: `&mut [String]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> crates/decompile/src/core/out/source.rs:325:38 | 325 | fn get_indentation_imbalance(source: &Vec<String>) -> i32 { | ^^^^^^^^^^^^ help: change this to: `&[String]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg </code></pre> Raw Output: crates/decompile/src/core/out/source.rs:325:38:w: <pre><code>warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> crates/decompile/src/core/out/source.rs:325:38 | 325 | fn get_indentation_imbalance(source: &Vec<String>) -> i32 { | ^^^^^^^^^^^^ help: change this to: `&[String]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: usage of a legacy numeric method --> crates/decompile/src/core/mod.rs:85:15 | 85 | u128::max_value(), | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 85 | u128::MAX, | ~~~ </code></pre> Raw Output: crates/decompile/src/core/mod.rs:85:15:w: <pre><code>warning: usage of a legacy numeric method --> crates/decompile/src/core/mod.rs:85:15 | 85 | u128::max_value(), | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 85 | u128::MAX, | ~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: variant name ends with the enum's name --> crates/cli/src/error.rs:6:5 | 6 | IOError(#[from] std::io::Error), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names = note: `#[warn(clippy::enum_variant_names)]` on by default </code></pre> Raw Output: crates/cli/src/error.rs:6:5:w: <pre><code>warning: variant name ends with the enum's name --> crates/cli/src/error.rs:6:5 | 6 | IOError(#[from] std::io::Error), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names = note: `#[warn(clippy::enum_variant_names)]` on by default </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: variant name ends with the enum's name --> crates/cli/src/error.rs:8:5 | 8 | SerdeError(#[from] serde_json::Error), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names </code></pre> Raw Output: crates/cli/src/error.rs:8:5:w: <pre><code>warning: variant name ends with the enum's name --> crates/cli/src/error.rs:8:5 | 8 | SerdeError(#[from] serde_json::Error), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: variant name ends with the enum's name --> crates/cli/src/error.rs:10:5 | 10 | DecompileError(#[from] heimdall_core::heimdall_decompiler::Error), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names </code></pre> Raw Output: crates/cli/src/error.rs:10:5:w: <pre><code>warning: variant name ends with the enum's name --> crates/cli/src/error.rs:10:5 | 10 | DecompileError(#[from] heimdall_core::heimdall_decompiler::Error), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: variant name ends with the enum's name --> crates/cli/src/error.rs:12:5 | 12 | DisassembleError(#[from] heimdall_core::heimdall_disassembler::Error), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names </code></pre> Raw Output: crates/cli/src/error.rs:12:5:w: <pre><code>warning: variant name ends with the enum's name --> crates/cli/src/error.rs:12:5 | 12 | DisassembleError(#[from] heimdall_core::heimdall_disassembler::Error), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names </code></pre> __END__

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.