fix(vm): clamp U256
conversions to <type>::MAX
#338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #332
Solution
When converting EVM values from
U256
to rust typesusize
andu128
, we clamp the values to<type>::MAX
rather than excepting. When symbolically executing a contract, we are bound to get huge and weird values, and we should support these cases without excepting.Culprit:
0x00000000000000ADc04C56Bf30aC9d3c0aAF14dC