Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow async output formats #507

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Conversation

zerodevx
Copy link
Contributor

@zerodevx zerodevx commented Feb 4, 2023

  • Quick Checklist
  • I have read the contributing guidelines
  • I have written new tests, as applicable (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • I have added a changeset, if applicable
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fixes #463 and #369 (comment), since it's possible that output format ops may be async.

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
    PR?)

Nope.

  • Other information:

I'm still facing an unrelated test failure on a brand new imagetools setup as described in #506. Happy to rebase if that get resolved.

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2023

🦋 Changeset detected

Latest commit: 8786522

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-imagetools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #507 (3baa612) into main (e1ea30e) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 3baa612 differs from pull request most recent head 8786522. Consider uploading reports for the commit 8786522 to get more accurate results

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
+ Coverage   96.95%   97.04%   +0.08%     
==========================================
  Files          33       33              
  Lines        1149     1149              
  Branches      238      239       +1     
==========================================
+ Hits         1114     1115       +1     
+ Misses         35       34       -1     
Flag Coverage Δ
imagetools-core 98.72% <ø> (ø)
rollup-plugin-imagetools 99.25% <ø> (ø)
vite-imagetools 85.71% <100.00%> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/vite/src/index.ts 85.43% <100.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@benmccann benmccann changed the title fix: allow async output formats feat: allow async output formats Apr 17, 2023
@benmccann benmccann merged commit 4306ad7 into JonasKruckenberg:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async output format
2 participants