Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filenames with spaces #670

Closed

Conversation

pzerelles
Copy link
Contributor

  • Quick Checklist
  • I have read the contributing guidelines
  • I have written new tests, as applicable (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • I have added a changeset, if applicable
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This is a bug fix to support image filenames with special characters like spaces.

  • What is the new behavior (if this is a feature change)?
    Image asset filenames will not be URL-encoded on disk, only for rendering.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
    PR?)
    I think no.

  • Other information:

Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: 708b404

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-imagetools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (fddbd1e) 93.60% compared to head (708b404) 93.24%.

Files Patch % Lines
packages/vite/src/index.ts 82.75% 5 Missing ⚠️
packages/vite/src/utils.ts 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
- Coverage   93.60%   93.24%   -0.37%     
==========================================
  Files          32       32              
  Lines        1189     1228      +39     
  Branches      189      196       +7     
==========================================
+ Hits         1113     1145      +32     
- Misses         76       83       +7     
Flag Coverage Δ
imagetools-core 97.01% <ø> (ø)
vite-imagetools 78.98% <81.39%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pzerelles pzerelles changed the title Fix filenames with spaces fix: filenames with spaces Dec 8, 2023
@benmccann
Copy link
Collaborator

This includes the change to #669, so we only need one

@benmccann
Copy link
Collaborator

I think we should probably not merge this workaround, but fix the underlying bug in Vite instead, which may be vitejs/vite#15298

@benmccann
Copy link
Collaborator

Closing in favor of vitejs/vite#15311

@benmccann benmccann closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants