refactor: always issue our own raw commands #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes running this role inside a docker container for the docker container also, removes much boilerplate at the cost of lost automatic changed_when's by ansible's modules
github-actions
bot
added
the
size/M
JonasPammer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes much boilerplate
removes community.general dependency
Fixes #37
Required Checklist
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Optional Checklist
pre-commit was installed in local development environment (if not, a GitHub workflow will run pre-commit once you create the request)
my commits are small, single-purpose, detailed and maybe even follow the conventional commit specification for extra convenience of the reviewer