Add backGestureDetectionStart parameter #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to control the start position of gesture detection area. Fix docs about backGestureDetectionWidth, because it does not to what is wriiten in the docs
JonasWanke
requested changes
Jun 8, 2021
Comment on lines
+47
to
+49
| /// If [canOnlySwipeFromEdge] is set to `true`, this value controls | ||
| /// width of gesture detection area | ||
| final double backGestureDetectionWidth; |
There was a problem hiding this comment.
Suggested change
| /// If [canOnlySwipeFromEdge] is set to `true`, this value controls | |
| /// width of gesture detection area | |
| final double backGestureDetectionWidth; | |
| /// If [canOnlySwipeFromEdge] is set to `true`, this value controls the width | |
| /// of the gesture detection area. | |
| /// | |
| /// For comparison, in [CupertinoPageRoute] this value is `20`. |
| /// | ||
| /// In [CupertinoPageRoute], this value is `20`. | ||
| final double backGestureDetectionWidth; | ||
| final double backGestureDetectionStart; |
There was a problem hiding this comment.
What do you think about renaming this to backGestureDetectionStartOffset? That might be more explicit and easier to understand without having to read the doc comment.
There was a problem hiding this comment.
backGestureDetectionStart looks fine
There was a problem hiding this comment.
Sorry, I mean backGestureDetectionStartOffset
You should fix change
JonasWanke
approved these changes
Jun 9, 2021
|
This is now published as part of v0.2.2. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13
Add ability to control the start position of gesture detection area.
Fix docs about backGestureDetectionWidth, because it does not to what is wriiten in the docs