-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use parent events and value on checkbox #5
base: master
Are you sure you want to change the base?
Conversation
davidmeirlevy
commented
Jun 30, 2019
- allows user to use "v-model" with all it's modifiers (because value binding and all related events are valid).
- reduce code, because now the component doesn't need to emit the change event manually.
- specify props types.
- add ability to add "name" attribute to the checkbox - needed for some forms.
1. allows user to use "v-model" with all it's modifiers (because value binding and all related events are valid). 2. reduce code, because now the component doesn't need to emit the change event manually. 3. specify props types. 4. add ability to add "name" attribute to the checkbox - needed for some forms.
3 is perfectly clear and I agree on it being a better addition.
|
|
Alright so to wrap up:
|
Readme file has changed. please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Reviewed the readme updates - added a few comments and suggestions
readme updated. please review again. |