Fix determine_output_filename function in api.py to handle appended numbers in file names #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umbers in file names
|
A little note: Should consider a ".editorconfig" that forces formatting to prevent the 100+ line "changes" as shown in the commit preview. |
|
Update: This change seems to have introduced a UI-breaking bug that seems to hit randomly. Will reopen once I find the cause. Edit: See the below comment. |
|
So, it seems the issue is coming from "Silence Between Segment". Unrelated to this change. Just happened to appear. The issue is still present without the change. |
|
Thanks, I'll look at this tonight. Yeah the filename stuff is a mess all over. Rip it all out and simply, some day. |
|
Added an issue for the .editorconfig, so I don't forget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The determine_output_filename function in the api.py file was not returning the correct file name when files had an appended number. This caused issues in the Gradio UI where the audio preview was not updating to newly generated files with appended numbers in their names.
This commit fixes the issue by updating the determine_output_filename function to correctly handle appended numbers in file names. Now, the function properly returns the correct file name, and the UI audio preview updates as expected.
Fixes issue #43