OS X Support #1
Merged
OS X Support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this looks good to me. Thanks for the PR! With this, hitting v1.0.0 looks pretty close. I can merge the Linux/macOS code in update.rs fairly easily. My only nitpick here is that I think the preferred way to refer to OS X now is as “macOS”, so I will probably change that wording. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to build and run SBR on OS X. I've tested this on catalina and it works fine provided you allow terminal the ability to monitor keyboard inputs (new security stuff i guess).
Here's a binary if anybody wants to try it out: shticker_book_unwritten_unstripped.zip
If you want any changes made, I will gladly make and test them. I will be upfront with the fact that my rust knowledge is limited and most of the changes were made by looking at existing code and adapting them to OS X.