Skip to content

Commit

Permalink
Cleanup syntax to appease linter
Browse files Browse the repository at this point in the history
  • Loading branch information
JonathanPorta committed Nov 29, 2014
1 parent 68f9cb6 commit 554678d
Show file tree
Hide file tree
Showing 10 changed files with 50 additions and 50 deletions.
17 changes: 9 additions & 8 deletions app/controllers/friendships_controller.rb
Expand Up @@ -83,13 +83,14 @@ def destroy
end

private
# Use callbacks to share common setup or constraints between actions.
def set_friendship
@friendship = Friendship.find(params[:id])
end

# Never trust parameters from the scary internet, only allow the white list through.
def friendship_params
params.require(:friendship).permit(:friend_id)
end
# Use callbacks to share common setup or constraints between actions.
def set_friendship
@friendship = Friendship.find(params[:id])
end

# Never trust parameters from the scary internet, only allow the white list through.
def friendship_params
params.require(:friendship).permit(:friend_id)
end
end
9 changes: 5 additions & 4 deletions app/controllers/users_controller.rb
Expand Up @@ -2,8 +2,9 @@ class UsersController < ApplicationController
before_action :set_user, only: []

private
# Use callbacks to share common setup or constraints between actions.
def set_user
@user = User.find(params[:id])
end

# Use callbacks to share common setup or constraints between actions.
def set_user
@user = User.find(params[:id])
end
end
1 change: 0 additions & 1 deletion app/decorators/friendship_decorator.rb
Expand Up @@ -9,5 +9,4 @@ class FriendshipDecorator < Draper::Decorator
# object.created_at.strftime("%a %m/%d/%y")
# end
# end

end
4 changes: 2 additions & 2 deletions app/models/user.rb
Expand Up @@ -4,10 +4,10 @@ class User < ActiveRecord::Base
has_many :messages, through: :activities

has_many :friendships
has_many :friends, -> { where.not(friendships: {approved: nil}) }, through: :friendships
has_many :friends, -> { where.not(friendships: { approved: nil }) }, through: :friendships

has_many :inverse_friendships, class_name: 'Friendship', foreign_key: 'friend_id'
has_many :inverse_friends, -> { where.not(friendships: {approved: nil}) }, through: :inverse_friendships, source: :user
has_many :inverse_friends, -> { where.not(friendships: { approved: nil }) }, through: :inverse_friendships, source: :user

validates :email, :first_name, :last_name, presence: true
validates :id, absence: true, on: :create
Expand Down
5 changes: 2 additions & 3 deletions spec/factories/friendships.rb
@@ -1,8 +1,7 @@
FactoryGirl.define do
factory :friendship do
user_id 1
friend_id 1
approved "2014-11-29 01:57:48"
friend_id 1
approved '2014-11-29 01:57:48'
end

end
32 changes: 16 additions & 16 deletions spec/routing/friendships_routing_spec.rb
@@ -1,34 +1,34 @@
require "rails_helper"
require 'rails_helper'

RSpec.describe FriendshipsController, type: :routing do
describe "routing" do
describe 'routing' do

it "routes to #index" do
expect(get: "/friendships").to route_to("friendships#index")
it 'routes to #index' do
expect(get: '/friendships').to route_to('friendships#index')
end

it "routes to #new" do
expect(get: "/friendships/new").to route_to("friendships#new")
it 'routes to #new' do
expect(get: '/friendships/new').to route_to('friendships#new')
end

it "routes to #show" do
expect(get: "/friendships/1").to route_to("friendships#show", id: "1")
it 'routes to #show' do
expect(get: '/friendships/1').to route_to('friendships#show', id: '1')
end

it "routes to #edit" do
expect(get: "/friendships/1/edit").to route_to("friendships#edit", id: "1")
it 'routes to #edit' do
expect(get: '/friendships/1/edit').to route_to('friendships#edit', id: '1')
end

it "routes to #create" do
expect(post: "/friendships").to route_to("friendships#create")
it 'routes to #create' do
expect(post: '/friendships').to route_to('friendships#create')
end

it "routes to #update" do
expect(put: "/friendships/1").to route_to("friendships#update", id: "1")
it 'routes to #update' do
expect(put: '/friendships/1').to route_to('friendships#update', id: '1')
end

it "routes to #destroy" do
expect(delete: "/friendships/1").to route_to("friendships#destroy", id: "1")
it 'routes to #destroy' do
expect(delete: '/friendships/1').to route_to('friendships#destroy', id: '1')
end

end
Expand Down
10 changes: 5 additions & 5 deletions spec/views/friendships/edit.html.erb_spec.rb
@@ -1,21 +1,21 @@
require 'rails_helper'

RSpec.describe "friendships/edit", type: :view do
RSpec.describe 'friendships/edit', type: :view do
before(:each) do
@friendship = assign(:friendship, Friendship.create!(
user_id: 1,
friend_id: 1
))
end

it "renders the edit friendship form" do
it 'renders the edit friendship form' do
render

assert_select "form[action=?][method=?]", friendship_path(@friendship), "post" do
assert_select 'form[action=?][method=?]', friendship_path(@friendship), 'post' do

assert_select "input#friendship_user_id[name=?]", "friendship[user_id]"
assert_select 'input#friendship_user_id[name=?]', 'friendship[user_id]'

assert_select "input#friendship_friend_id[name=?]", "friendship[friend_id]"
assert_select 'input#friendship_friend_id[name=?]', 'friendship[friend_id]'
end
end
end
8 changes: 4 additions & 4 deletions spec/views/friendships/index.html.erb_spec.rb
@@ -1,6 +1,6 @@
require 'rails_helper'

RSpec.describe "friendships/index", type: :view do
RSpec.describe 'friendships/index', type: :view do
before(:each) do
assign(:friendships, [
Friendship.create!(
Expand All @@ -14,9 +14,9 @@
])
end

it "renders a list of friendships" do
it 'renders a list of friendships' do
render
assert_select "tr>td", text: 1.to_s, count: 2
assert_select "tr>td", text: 2.to_s, count: 2
assert_select 'tr>td', text: 1.to_s, count: 2
assert_select 'tr>td', text: 2.to_s, count: 2
end
end
10 changes: 5 additions & 5 deletions spec/views/friendships/new.html.erb_spec.rb
@@ -1,21 +1,21 @@
require 'rails_helper'

RSpec.describe "friendships/new", type: :view do
RSpec.describe 'friendships/new', type: :view do
before(:each) do
assign(:friendship, Friendship.new(
user_id: 1,
friend_id: 1
))
end

it "renders new friendship form" do
it 'renders new friendship form' do
render

assert_select "form[action=?][method=?]", friendships_path, "post" do
assert_select 'form[action=?][method=?]', friendships_path, 'post' do

assert_select "input#friendship_user_id[name=?]", "friendship[user_id]"
assert_select 'input#friendship_user_id[name=?]', 'friendship[user_id]'

assert_select "input#friendship_friend_id[name=?]", "friendship[friend_id]"
assert_select 'input#friendship_friend_id[name=?]', 'friendship[friend_id]'
end
end
end
4 changes: 2 additions & 2 deletions spec/views/friendships/show.html.erb_spec.rb
@@ -1,14 +1,14 @@
require 'rails_helper'

RSpec.describe "friendships/show", type: :view do
RSpec.describe 'friendships/show', type: :view do
before(:each) do
@friendship = assign(:friendship, Friendship.create!(
user_id: 1,
friend_id: 2
))
end

it "renders attributes in <p>" do
it 'renders attributes in <p>' do
render
expect(rendered).to match(/1/)
expect(rendered).to match(/2/)
Expand Down

0 comments on commit 554678d

Please sign in to comment.