You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice commit. However I have a suggestion. Your optimization does not perform anything if there is at least on symbolic variable in the expression which prevents folding any foldable sub-expressions.
Thus something like bvadd(bvadd(4, 5), x) will never get simplified. By construction it seems unlikely that such expressions will get created, but by means of constant propagation that will likely happen.
Some AST simplification can be performed in the
AstContext::extract
. Especially an extract on a constant value can be simplified.This can be easily implemented in : https://github.com/JonathanSalwan/Triton/blob/master/src/libtriton/ast/astContext.cpp#L594
I will implement it and do the PR. (creating the issue for the record)
The text was updated successfully, but these errors were encountered: