Cleanup #13
Cleanup #13
Conversation
Using git master could easily break in between releases. Using the file method lets us stay on a stable release. It makes the most sense for a default.
This makes it so we don't need to install unzip to extract the file. Most if not all linux servers will come with tar installed.
config.js could contain username and passwords for graphite and may contain more sensitive information in the future.
According to FHS /srv is the proper location for www, ftp, and any other data served by the system. http://www.pathname.com/fhs/pub/fhs-2.3.html#SRVDATAFORSERVICESPROVIDEDBYSYSTEM
|
I should also note I changed the default installation method to file. Using git master is probably a bit risky, a single commit could break things. I switched it over to use the file install_type by default so the cookbook can follow stable releases. Git is always there if someone actually needs it. |
|
Thanks for your hard work. |
|
Thanks for the merge! 🍻 |
|
@gregf Can you please explain a little bit how installation path /opt violates FHS? I checked the relevant section in the document but could not find the answer |
|
@arifcse019 My thoughts were based on what the definition of /srv says, which can be found here Which basically says /srv is for site specific data including opt talks about configuration files and static binary packages. I don't see anything that mentions the type of files we're are storing here. I'm open to other thoughts on the matter though, so let me know if I'm missing something. |
|
Thanks and Disclaimer: I am not a pro in Unix system administration. Just trying to better understand why things are done in certain way. So under FHS definition. /srv is for data but not the applications that serve those data about the sites hosted on the machine. What do you think? |
|
@arifcse019 Sounds good |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I been working on cleaning some stuff up in the cookbook and adding some more tests.
One notable change is, I changed the default location from /opt /srv/apps based on FHS.
Just about everything else was test related or rubocop related.