Fix non-writable home directory #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, if the home directory already existed (because the scuba workdir was bind-mounted somewhere underneath it), then the home directory would remain owned by root. Removing this check ensures that the chown() always happens. The only odd thing remaining is that any other directories from $HOME down to the workdir will remain owned as root. This fixes #168
JonathonReinhart
force-pushed
the
168-writable-home
branch
from
437afa3
to
3bee7c8
Compare
This is an attempt to ensure #168 is covered by a test. This only happens when scuba is run from somewhere under /home/$username, so we issue a warning if the test is unable to do that.
JonathonReinhart
force-pushed
the
168-writable-home
branch
from
3bee7c8
to
d6887a4
Compare
JonathonReinhart
added a commit
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168.