-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations #207
Add type annotations #207
Commits on Apr 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2f06f4e - Browse repository at this point
Copy the full SHA 2f06f4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3e9408 - Browse repository at this point
Copy the full SHA c3e9408View commit details -
Add type annotations to scuba.dockerutil
This also necessitated a few refactors: - Replace __wrap_docker_exec() with straightforward implementations - Move error message into DockerExecuteError.__init__ - Refactor out common behavior into _get_image_config()
Configuration menu - View commit details
-
Copy full SHA for 97c36f8 - Browse repository at this point
Copy the full SHA 97c36f8View commit details -
Add type annotations to scuba.version
Also, change git_describe() to return a GitDescribe dataclass result.
Configuration menu - View commit details
-
Copy full SHA for 4605c20 - Browse repository at this point
Copy the full SHA 4605c20View commit details -
Add type annotations to scuba.config
Other notable changes: - ScubaAlias, ScubaVolume are now frozen dataclass classes - Added Loader._rooted_loader to satisfy requirement that yaml.load's second parameter must be a Type - Added _get_str() - Added 'default' parameter to _get_typed_val()
Configuration menu - View commit details
-
Copy full SHA for bd487fb - Browse repository at this point
Copy the full SHA bd487fbView commit details -
Add type annotations to scuba.scuba
Notable changes: - Made ScubaContext a dataclass with non-optional members. This required significant changes in ScubaContext.process_command(), since all values must be known when the object is constructed, and not default to None to be updated later in the function. - ScubaContext.process_command() image and shell arguments were renamed to add _override to clarify their behavior. Notable gaps: - open_scubadir_file() returns Any because I couldn't figure out how to correctly annotate a TextIO object with an additional container_path attribute.
Configuration menu - View commit details
-
Copy full SHA for d1daf0a - Browse repository at this point
Copy the full SHA d1daf0aView commit details -
Add type annotations to scuba.__main__
Move argcomplete stub to its own module.
Configuration menu - View commit details
-
Copy full SHA for f016852 - Browse repository at this point
Copy the full SHA f016852View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8056ad - Browse repository at this point
Copy the full SHA d8056adView commit details
Commits on Apr 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 948e7e6 - Browse repository at this point
Copy the full SHA 948e7e6View commit details