Cleanup and refactor tests #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 6 files 6 suites 2m 4s ⏱️ Results for commit fe16200. ♻️ This comment has been updated with latest results. |
JonathonReinhart
force-pushed
the
test-cleanup
branch
from
d2ac8b3
to
df2129a
Compare
Also, make error_match a keyword-only argument.
JonathonReinhart
force-pushed
the
test-cleanup
branch
from
df2129a
to
5723139
Compare
These tests are currently unusable (skipped) because Pytest never runs with stdin connected to the actual tty (even when run locally). But this at leasts updates the tests to be consistent with others. Test: Locally removed isatty() assert and @skipUnlessTty() decorators and verified tests fail in an expected manner.
These are just not worth the effort to properly annotate!
This previously applied only to the scuba package but now applies to tests as well.
JonathonReinhart
force-pushed
the
test-cleanup
branch
from
5723139
to
e656eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.