219 no bindmount leak #252
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works if scubaroot = /home/$USER: is_bind_mount() detects the bind mount because we're trying to mount the /jreinhart subdirectory of the /home/ mount: scubainit: ERROR - Error creating home dir: "/home/jreinhart" is on a bind-mount: /dev/mapper/magnum--vg-home[/jreinhart] But it fails for scubaroot = /home: is_bind_mount() sees root="/" and returns false. I think there is simply no way to reliably detect a bind mount! So now we might be to the point of either passing the list of bind-mount volumes from scuba to scubainit, or by checking for this situation in scuba instead.
Test Results 6 files 6 suites 2m 1s ⏱️ Results for commit 6f50a85. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.