Persist LD_LIBRARY_PATH when invoking ldd #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This phase of staticx, library path discovery, is intended to run in
whatever environment the user has created. That means we should keep the
value of LD_LIBRARY_PATH when invoking ldd.
The existing ('if libpath') already handled the case where LD_LIBRARY_PATH
is in the env and properly prepended to it. But LD_LIBRARY_PATH could
never be in the empty env.
This change simply keeps LD_LIBRARY_PATH.
Fixes #184
We already check 'if libpath' so there's no need for the empty list when None will suffice.
m0nzderr
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #184.