Eliminate problematic getxxnam() calls in bootloader #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to convert for output purposes, just show it. This is part of the mission to eliminate th_get_uid()/th_get_gid() which call the problematic (and for staticx, unnecessary) getpwnam/getgrname.
Also remove the dead code that would fchown(uid,gid).
These remove the last problematic getxxnam() calls in libtar
This turns warnings like this into fatal errors, because as we've seen,
especially with staticx's goals in mind, these are real problems:
libtar/decode.c:49: warning: Using 'getpwnam' in statically linked
applications requires at runtime the shared libraries from the glibc
version used for linking
JonathonReinhart
force-pushed
the
227-static-glibc-uses-nss
branch
from
15e6322
to
3acfbaa
Compare
JonathonReinhart
changed the title
|
Confirmed that |
JonathonReinhart
added
nss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glibc warns us that we shouldn't call functions like
getpwnam()from a statically-linked application:The reason is that it will actually dlopen() the libnss libraries, and then possibly explode.
This PR eliminates the
getpwnam/getgrnamcalls fromlibtar, and adds a linker flag to make sure it doesn't happen again.Note that libtar keeps losing more and more fingers, but that's okay because we don't really need much of its functionality. See also #229 because this is annoying.
Fixes #227.