Trim libtar and refactor bootloader's usage #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bootloader only cares to extract tar files.
After making libtar readonly, the only place the hash was used was during extration in tar_extract_hardlink(). The code had a fallback path which would call th_get_linkname() if libtar_hash_getkey() failed. We simply always use that slow(?) path, and remove listhash altogether. We also remove some hash functions from util.c
We leave th_print_long_ls() as it's used by tar_extract_all() with TAR_VERBOSE.
This was referenced Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a lot of code in libtar that dealt with creating
or modifying tar files, which was never used by the
bootloader, but included in the statically-linked
executable.
constto a lot of API parametersdecompression code in the bootloader