Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remove ancestor markers crash #413

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fix remove ancestor markers crash #413

merged 2 commits into from
Jul 11, 2024

Conversation

JonasAAA
Copy link
Contributor

Objective

Fix the issue where remove_ancestor_markers crashes if an entity has children moved or removed, and then is despawned before remove_ancestor_markers is run.

Solution

When remove component from an entity, just check if that entity exists first.

@Jondolf Jondolf added the bugfix label Jul 10, 2024
Jondolf
Jondolf approved these changes Jul 11, 2024
View reviewed changes
Copy link
Owner

@Jondolf Jondolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch! I appreciate the regression test as well :)

@Jondolf Jondolf merged commit db535b2 into Jondolf:main Jul 11, 2024
4 checks passed
@JonasAAA JonasAAA deleted the fix-remove-ancestor-markers-crash branch July 14, 2024 05:42
@Jondolf Jondolf added C-Bug Something isn't working P-Crash A sudden unexpected crash and removed bugfix labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jondolf Jondolf Jondolf approved these changes

Assignees
No one assigned
Labels
C-Bug Something isn't working P-Crash A sudden unexpected crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonasAAA @Jondolf