Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows dynamic import protocol issue #268

Merged
merged 1 commit into from
Nov 11, 2023
Merged

fix: windows dynamic import protocol issue #268

merged 1 commit into from
Nov 11, 2023

Conversation

Jonghakseo
Copy link
Owner

@Jonghakseo
Copy link
Owner Author

@PatrykKuniczak

It works on Windows11 (ARM) in the VM.

스크린샷 2023-11-12 오전 3 39 40

@Jonghakseo Jonghakseo changed the title Fix windows dynamic import protocol issue fix: windows dynamic import protocol issue Nov 11, 2023
PatrykKuniczak
PatrykKuniczak approved these changes Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@PatrykKuniczak PatrykKuniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works also on my machine, awesome :)

@Jonghakseo Jonghakseo merged commit de514ed into main Nov 11, 2023
5 checks passed
@Jonghakseo Jonghakseo deleted the fix/reload-when-manifest-modified branch November 11, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrykKuniczak PatrykKuniczak PatrykKuniczak approved these changes

Assignees

@Jonghakseo Jonghakseo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jonghakseo @PatrykKuniczak