Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] isStackOnBottom and stackedCardsCount not working on 2.3.0 #78

Closed
IDontEatMeat opened this issue Nov 3, 2020 · 5 comments
Closed

[Bug] isStackOnBottom and stackedCardsCount not working on 2.3.0 #78

IDontEatMeat opened this issue Nov 3, 2020 · 5 comments
Labels
bug

Comments

@IDontEatMeat
Copy link

IDontEatMeat commented Nov 3, 2020 •
edited

Bottom stacking won't work anymore with 2.3.0. I had to downgrade after wasting 3 hours not knowing what is going on. If someone else encounters this issue it is because of the new version. stackedCardsCount and isStackOnBottom have no effect whatsoever.
@JoniVR
Copy link
Owner

JoniVR commented Nov 5, 2020

Hi, you are correct, I've discovered the issue was introduced in #76, will work on a fix.

@JoniVR JoniVR added the bug label Nov 5, 2020
@JoniVR JoniVR changed the title The bottom stacking doesn't work anymore with the new update [Bug] [Bug] isStackOnBottom and stackedCardsCount not working on 2.3.0 Nov 5, 2020
@IDontEatMeat
Copy link
Author

Thanks, great project btw 👍

stfnhdr pushed a commit to stfnhdr/VerticalCardSwiper that referenced this issue Jan 2, 2021
fixed [Bug] isStackOnBottom and stackedCardsCount not working on …
ce1c6e6 
…2.3.0 JoniVR#78
@stfnhdr stfnhdr mentioned this issue Jan 2, 2021
Merged
4 tasks
@stfnhdr
Copy link
Contributor

stfnhdr commented Jan 2, 2021

fixed issue in PR #79

stfnhdr pushed a commit to stfnhdr/VerticalCardSwiper that referenced this issue Jan 2, 2021
Merge branch 'bug/sth-78'
8feacb7 
* bug/sth-78: (22 commits)
  fixed [Bug] `isStackOnBottom` and `stackedCardsCount` not working on 2.3.0 JoniVR#78
  Release 2.3.0
  Update scale animation to transform both x and y values (JoniVR#76)
  Update test configs
  Add `cardForItem` function to `VerticalCardSwiper`
  Fix example background color
  Release 2.2.0
  Update readme
  Migrate to Github Actions for CI (JoniVR#67)
  Add `didCancelSwipe` delegate method; Fix `swipeCardAwayProgrammatically` not working after cancelling manual swipe
  Fix `swipeCardAwayProgrammatically` not working in certain cases
  Release 2.1.0
  Update SPM support (JoniVR#63)
  Add Carthage install instructions
  Add `swipeCardAwayProgrammatically` function to `VerticalCardSwiper`, Minor tweaks
  release 2.0.1
  improve paging algorithm to account for zero velocity
  Update issue templates
  Update question.md
  release 2.0.0 🎉
  ...

# Conflicts:
#	Example/Base.lproj/Main.storyboard
#	Sources/VerticalCardSwiperFlowLayout.swift
#	VerticalCardSwiper.xcodeproj/project.pbxproj
#	VerticalCardSwiper.xcodeproj/xcshareddata/xcschemes/Example.xcscheme
#	VerticalCardSwiper.xcodeproj/xcshareddata/xcschemes/UITests.xcscheme
#	VerticalCardSwiper.xcodeproj/xcshareddata/xcschemes/VerticalCardSwiper.xcscheme
@IDontEatMeat
Copy link
Author

awesome thanks

@JoniVR
Copy link
Owner

JoniVR commented Jan 12, 2021

This is now fixed in the new release, thanks @stfnhdr for opening a PR and @IDontEatMeat for reporting!

@JoniVR JoniVR closed this as completed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JoniVR @stfnhdr @IDontEatMeat