Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages with discisrc when there are no ISRCs on disc #51

Closed
JonnyJD opened this issue Mar 12, 2013 · 1 comment
Closed

Error messages with discisrc when there are no ISRCs on disc #51

JonnyJD opened this issue Mar 12, 2013 · 1 comment
Assignees
@JonnyJD
Labels
backend usability
Milestone
1.0.1

Comments

@JonnyJD
Copy link
Owner

JonnyJD commented Mar 12, 2013

When no ISRCs are on the disc, discisrc still prints Track #: for every Track.
This then leads to:

can't find ISRC in: Track 1  : 

can't find ISRC in: Track 2  : 

can't find ISRC in: Track 3  : 

...

Other backends just keep quiet and tell "no new ISRCs found" a the end.
@ghost ghost assigned JonnyJD Mar 12, 2013
JonnyJD added a commit that referenced this issue Mar 12, 2013
@JonnyJD
no errors on discisrc with no isrcs, re #51 (v2)
fabb325 
Discisrc displays one line for each track,
even when no ISRCs are found.
JonnyJD added a commit that referenced this issue Mar 12, 2013
@JonnyJD
no errors on discisrc with no isrcs, close #51 (v1)
ea68af0 
Discisrc displays one line for each track,
even when no ISRCs are found.

Discisrc just ignores these empty ISRCs now.
@JonnyJD
Copy link
Owner Author

JonnyJD commented Mar 12, 2013

Hm, since v1 is not the master branch anymore -> closed manually.

@JonnyJD JonnyJD closed this as completed Mar 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonnyJD JonnyJD

Labels
backend usability
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
1 participant
@JonnyJD