put() takes parameters in a weird format that now isn't even given by discid

[JonnyJD]

The offsets parameter wants the first item to be the number of sectors in the disc and the rest of the list to be track offsets.
We should split that to two parameters, especially now, since we don't provide a similar list anymore.

[JonnyJD]

This is of course related to the changes introduced for #24 and #27.

The downside, if we change this, is that our parameters are different then the ones libdiscid expects directly. We are not the only binding changing that though.

[JonnyJD]

I want to note, that I don't want to remove either of the parameters first and last. While technically possible, since that can be guessed from the length of the offsets, I want them as another sanity check to make sure that we don't get bogus disc IDs.
The internal check is done in 08d1cde. Since there are different methods of handing over the sector count and the offsets, I check the length against the track numbers.

[phw]

The difference between output and input is a point that should be considered. rb-discid has that issue, too. Maybe there should be an offsets property on the disc object with the correct format? What do you think?

I would also definitely keep the parameter first. For last rb-discid makes the assumption that it can be calculated from first and the offset length, which should be fine since the numbering is consecutive. However having it as an explicit parameter is probably more clear to the user and allows for extended input validation. Either way is fine.

[JonnyJD]

@phw:
The Disc.offsets property goes into the direction of http://tickets.musicbrainz.org/browse/LIB-41 (TOC "id").
I am thinking about implementing Disc.toc in python-only (so it doesn't depend on a new libdiscid version).

The difference between Disc.toc and Disc.offsets is:
The toc can be used as an input for a MusicBrainz query. However, except for internal testing, there is no good reason to use python-discid to generate Disc.offsets just to then use this as an input for put().