-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed importing errors in tests. #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These import paths looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might as well remove generate_LncRNA2Target
since their database is no longer publicly available or actively updated (though I have a copy of their data).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with these changes. I've actually made the same updates in master as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This had an error at index="gene_name"
because I recently changed the function to take in a list
or pd.Index
of gene ids/names, not just the string of index name
.
I'd still keep data.initialize_annotations()
if possible, since we need make sure data.annotations
df gets instantiated. In the future we might want MessengerRNA.__init__()
to automatically run initialize_annotations()
so the users doesn't have to remember run it before they .annotate_attributes()
.
keeping `data.initialize_annotations()`, since we might need `generate_TCGA_LUAD_MessengerRNA_dask` to have future tests on `.annotate_attributes()` with Dask.
Hey! I'm going to work more on the testing and whatnot. Grad school got me sidetracked a bit! Excited to work more on this. |
No problem, totally understand! This is a side project of mine too, but I'm so glad you're interested on working on it! As far as the current development state, I make new contributions to OpenOmics whenever I need it to do something to support my research work. But, I'm hoping to learn more about how others (like you) uses it for your own research, so it'll be more useful for the overall bioinf research community. When you have time, can you list some new features you'd like to see or pain-points you'd like to be fixed? I've made a project board at https://github.com/JonnyTran/OpenOmics/projects/2. You can drop a TODO list there, and I'll go over it. If you'd like to chat over a Slack group, I can make one too! |
Hey @JonnyTran - I had some life stuff happen, but I am back into things now. If you have an PRs or whatnot that you want reviewed, feel free to send them my way as well. I'd love to discuss more on how I'm using this in my work. |
Thank you @sdhutchins, let me know you need anything, especially with access to certain databases or certain analytic use cases. I haven't been contributing to the package recently but will get back to it. I can send you an email with a few survey question on usability and user experiences, and we can follow up from there. |
Please do! My email is in my profile. |
I've linked this PR to an issue as well.