Improve UndefinedOr and tests
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonxslays
added
enhancement
Jonxslays
pushed a commit
that referenced
this pull request
Aug 27, 2023
* Adding some docs, fixes teams to workspacs * style(CreateKey.tsx): remove trailing whitespace style(page.tsx): remove trailing whitespace style(client.tsx): remove unused imports and trailing whitespace --------- Co-authored-by: James Perkins <jamesperkins@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds more test coverage. Not all the way there but solid enough for the first release.
It also improves the usage of
UndefinedOr:Derefimplementation in favor of a new methodpub fn inner(&self) -> Option<&T>.Checklist
cargo testand all tests pass.cargo fmtand the code is formatted.cargo clippyin pedantic mode and refactored.Related Issues