Adapt image processing settings to JoomIMGtools #65
Conversation
add the new argument "$unsharp" to all the JoomIMGtools::resizeImage() calls.
rebase with PR JoomGalleryfriends#60
first commit - propably full of bugs
update script created, in order to adjust current settings according to the new configurations.
rebase with PR JoomGalleryfriends#60
when upgrading from Version <= 3.5.x jg_maxheight doesn' exist. We need to set jg_maxheight equal to jg_maxwidth in this case.
It is not possible to register an already existing Class in php. Thtas why JDatabase is used to store the updated configs instead of JTable...
Previews of the image walls (gallery, category, favorites, toplist view) that would be created using the specific setting value for thumbnail conversion.
PHP Notice: Undefined variable: autorot_orig in ...\administrator\components\com_joomgallery\helpers\upload.php on line 2271
in order to fulfill backward compatibility
With the watermark position 'top left' with GD2 as image editor, the rest of the image was "darkened".
It is still not possible to add a resized watermark on an animated gif using IM.
based on the rearrangement, some references in other configuration descriptions has to change
|
Here is a short video for better understanding how the tool to check and optimize the image processing configuration is designed to work. Please leave a comment if you would like any changes in this behaviour or design of the tool. optimize_settings.mp4 |
Elfangor93
added
the
needs testing
|
In the area where you can "check and optimize your currently set options" I compared two images ("compare images"). In the pop-up window at the bottom left, I change the "width" to a size (pixel) that is larger than the size of my screen (e.g. 1500 width). Then the popup window is so big that I can't get the value reset. I can only close it at the top right!
|
| <p><strong <?php echo JHTML::_('joomgallery.tip', JText::_('COM_JOOMGALLERY_CONFIG_GS_IP_TEST_GENTIME_TXT'), JText::_('COM_JOOMGALLERY_CONFIG_GS_IP_TEST_GENTIME_LBL'), true); ?>><?php echo JText::_('COM_JOOMGALLERY_CONFIG_GS_IP_TEST_GENTIME_LBL');?>:</strong> <?php echo round($info->detailL->processing_time,3);?> sec</p> | ||
| <p><strong <?php echo JHTML::_('joomgallery.tip', JText::_('COM_JOOMGALLERY_CONFIG_GS_IP_TEST_GENMEMORY_TXT'), JText::_('COM_JOOMGALLERY_CONFIG_GS_IP_TEST_GENMEMORY_LBL'), true); ?>><?php echo JText::_('COM_JOOMGALLERY_CONFIG_GS_IP_TEST_GENMEMORY_LBL');?>:</strong> <?php echo round(($info->detailL->used_memory) / pow(1000,2),2);?> MB</p> | ||
| <?php else: ?> |
There was a problem hiding this comment.
Add
<p><strong <?php echo JHTML::_('joomgallery.tip', JText::_('COM_JOOMGALLERY_CONFIG_GS_IP_TEST_QUALITY_TXT'), JText::_('COM_JOOMGALLERY_CONFIG_GS_IP_TEST_QUALITY_LBL'), true); ?>><?php echo JText::_('COM_JOOMGALLERY_CONFIG_GS_IP_TEST_QUALITY');?>:</strong> <?php echo ($info->detailL->used_quality);?></p>
to show the quality parameter
|
One more suggestion: |
Right now, this feature is realized with using pure HTML/CSS. The apperience of the slider is then done by the browser you are using. If we would like it more userfriendly, we need to use a javascript library to create the slider. This I wanted to avoid. Thats why it is like it is... |
Image processing settings in the configuration manager: When popup window gets to big it was not possible to rescale the window anymore.
OK, if it's not easy to change we can leave it as it is. |
In the configuration optimization tool the quality parameter is added to the info screen
Styling of the resizer of the configuration optimization tool
Elfangor93
force-pushed
the
imgProcess-settings-cp
branch
2 times, most recently
from
42a9348
to
a6f5469
Compare
The sheer volume of configuration options in the configuration manager may be confusing for JoomGallery users.
This pull request is intended to provide a better structure and explanation of the options concerning image processing. It introduces a new tab under the tab "frontend settings" called "image processing". All options concerning image processing can be found now in one of these two tabs for image processing options:
The options are arranged in both tabs regarding the image that is affected from this option (original image, detail image, thumbnail). This is intended to result in a more logical structure of the options. The description of the options has been changed at some places so that they are better aligned to each other and correctly reflect the behaviour of the JoomIMGtools class.
Additionally a tool to check and optimize your currently set options was added.
It is placed on the bottom of the
General Settings/Image Processingtab. This tool allows you to upload an image of your choice and apply your settings to the uploaded image creating versions of thumbnail and detail images. You can generate up to two versions of each image (ideally generated with different settings). The tool allows you to directly compair the two images generated and to see the resulting differences.This way, the image processing options can be optimized for any application without the need to add images to the database. The images uploaded and created by this tool are stored in the JoomGallery tmp-folder. Only one image at a time can exist in the tmp-folder. If a new image is generated or uploaded, the old one is overwritten.