Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External search engines integration #93

Merged
merged 4 commits into from Jun 29, 2022

Conversation

Elfangor93
Copy link
Member

@Elfangor93 Elfangor93 commented Oct 12, 2021

This PR integrates external search engines into JoomGallery. External search engines needs to have a Plugin of group="joomgallery" and the plugin events "onJoomSearchEngineGetName" and "onJoomSearch".
A configuration option is added to the configuration manager. The option is found in the search tab. Any external search engine which has a JoomGallery-Plugin installed and enabled will be listed there in the config manager. There you can select which search engine you want to use to create the search view.
The serach form field in the header of JoomGallery will generate the search view based on the selected search engine.

Prerequirements

Info

Since this PR depends on the PR #78 I will do a rebase as soon as the PR #78 is merged and change this PR from 'Draft' to 'Ready for review'.

@Elfangor93 Elfangor93 added the enhancement New feature or request label Oct 12, 2021
@Elfangor93 Elfangor93 changed the title External serach engines integration External search engines integration Mar 16, 2022
@Elfangor93 Elfangor93 marked this pull request as ready for review March 16, 2022 19:46
@Elfangor93
Copy link
Member Author

Rebased with v3.6.0...

@Elfangor93 Elfangor93 added the needs testing This issue or pull request needs further testing label Mar 22, 2022
@MrMusic
Copy link
Member

MrMusic commented Mar 28, 2022

Sometimes the search result are wrong

Steps to reproduce the issue

Install last JoomFinder package
Set SmartSearch as search engine in JoomGallery Configuration Manager
Go to Component -> Smart Search -> Options: Set 'Allow Empty Search' to Yes
Enter a wrong search term in JoomGallery component search box, example: 'xxx'

Expected result
Search result: There were no images found that match the search pattern!

Actual result
All images are found/shown

Hint: When using Joomla Smart Search component the search result is correct (No Results Found)

System information
Joomla 3.10.6
PHP 8.0.10

@Elfangor93
Copy link
Member Author

Elfangor93 commented May 30, 2022

I can confirm this issue.
But the issue is created in the Smart Search component (com_finder) not in the finder plugin and not in the JoomGallery.

Steps to reproduce the issue in smart search:

  • Install last JoomFinder package
  • Go to Component -> Smart Search -> Options: Set 'Allow Empty Search' to Yes
  • Go to Component -> Smart Search -> Press "Index" button to start first indexing of content
  • Enter a wrong search term in the smart search by applying the filter "Search by Type" = "Image (JoomGallery)"

This is what the JoomGallery-Search is performing in the back when searching for a specific term in the gallery search field. The plugin is performing a smart search with the applied filter "Search by Type" = "Image (JoomGallery)".

Therefore, to solve this issue the corresponding issue in com_finder has to be solved...

@MrMusic
Copy link
Member

MrMusic commented Jun 29, 2022

Therefore, to solve this issue the corresponding issue in com_finder has to be solved...

Ok, if it's not a bug in the finder plugin there's probably nothing you can do here...

I have tested this item ✅ successfully. Thank you very much.

@MrMusic MrMusic merged commit 9849000 into JoomGalleryfriends:v3.6.0 Jun 29, 2022
@MrMusic MrMusic removed enhancement New feature or request needs testing This issue or pull request needs further testing labels Jun 29, 2022
@Elfangor93 Elfangor93 deleted the searchIntegration branch March 27, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants