New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External search engines integration #93
External search engines integration #93
Conversation
fbe7add
to
9660e81
Compare
e80f8ec
to
0ce7f7d
Compare
Rebased with v3.6.0... |
Sometimes the search result are wrong Steps to reproduce the issue Install last JoomFinder package Expected result Actual result Hint: When using Joomla Smart Search component the search result is correct (No Results Found) System information |
I can confirm this issue. Steps to reproduce the issue in smart search:
This is what the JoomGallery-Search is performing in the back when searching for a specific term in the gallery search field. The plugin is performing a smart search with the applied filter "Search by Type" = "Image (JoomGallery)". Therefore, to solve this issue the corresponding issue in com_finder has to be solved... |
Ok, if it's not a bug in the finder plugin there's probably nothing you can do here... I have tested this item ✅ successfully. Thank you very much. |
This PR integrates external search engines into JoomGallery. External search engines needs to have a Plugin of group="joomgallery" and the plugin events "onJoomSearchEngineGetName" and "onJoomSearch".
A configuration option is added to the configuration manager. The option is found in the search tab. Any external search engine which has a JoomGallery-Plugin installed and enabled will be listed there in the config manager. There you can select which search engine you want to use to create the search view.
The serach form field in the header of JoomGallery will generate the search view based on the selected search engine.
Prerequirements
Info
Since this PR depends on the PR #78 I will do a rebase as soon as the PR #78 is merged and change this PR from 'Draft' to 'Ready for review'.