Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyscf's hcore function rather than handrolled #177

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

fdmalone
Copy link
Collaborator

Should be less error prone. Addresses #176 .

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #177 (ce184e2) into develop (264ccee) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #177      +/-   ##
===========================================
- Coverage    55.23%   55.23%   -0.01%     
===========================================
  Files          165      165              
  Lines        23674    23670       -4     
===========================================
- Hits         13077    13074       -3     
+ Misses       10597    10596       -1     
Impacted Files Coverage Δ
ipie/utils/from_pyscf.py 57.49% <100.00%> (-0.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@linusjoonho linusjoonho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linusjoonho linusjoonho merged commit 44ed905 into develop Nov 14, 2022
@fdmalone fdmalone deleted the fix_hcore_build branch December 23, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants